jedcunningham commented on code in PR #39309: URL: https://github.com/apache/airflow/pull/39309#discussion_r1583341982
########## RELEASE_NOTES.rst: ########## @@ -21,6 +21,96 @@ .. towncrier release notes start +Airflow 2.9.1 (2024-05-03) +-------------------------- + +Significant Changes +^^^^^^^^^^^^^^^^^^^ + +Rename the ``name`` attribute of the StackdriverTaskHandler to ``gcp_log_name`` to avoid name overriding by the the ``DictConfigurator`` (#38071). +"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""" + +Airflow relies on the ``logging.config.dictConfig`` (`documentation <https://docs.python.org/3/library/logging.config.html>`_) method +to `setup the logging stack <https://github.com/apache/airflow/blob/a58441ca1b263cae61a5bb653e6839f0dd29b08e/airflow/logging_config.py#L69>`_. +However, during this setup, it iterates through the handlers and +`explicitly sets their name <https://github.com/python/cpython/blob/2a4cbf17af19a01d942f9579342f77c39fbd23c4/Lib/logging/config.py#L578>`_: + +.. code-block:: python + + for name in sorted(handlers): + try: + handler = self.configure_handler(handlers[name]) + handler.name = name + handlers[name] = handler + except Exception as e: + # [...] + pass + +So, before this fix: + +#. You setup the remote logging through the environment variables ``AIRFLOW__LOGGING__REMOTE_LOGGING="true"`` and ``AIRFLOW__LOGGING__REMOTE_BASE_LOG_FOLDER="stackdriver://host/path"``. +#. Airflow instantiates a ``StackdriverTaskHandler`` with the name of ``"path"`` +#. **BUT** the ``dictConfig`` call overrides the name of the handler with the key of the handlers configuration (i.e. `task <https://github.com/apache/airflow/blob/a58441ca1b263cae61a5bb653e6839f0dd29b08e/airflow/config_templates/airflow_local_settings.py#L350>`_). +#. Hence, the next calls to the ``emit`` method of the handler will generate logs to the wrong destination (``task`` instead of ``path``). + +Changing the field, from ``name`` to ``gcp_log_name`` prevents the overriding from the ``dictConfig``. + +Bug Fixes +""""""""" +- Make task log messages include run_id (#39280) +- Copy menu_item ``href`` for nav bar (#39282) +- Fix trigger kwarg encryption migration (#39246) +- Add workaround for datetime-local input in ``firefox`` (#39261) +- Add Grid button to Task Instance view (#39223) +- Get served logs when remote or executor logs not available for non-running task try (#39177) +- Fixed side effect of menu filtering causing disappearing menus (#39229) +- Use grid view for Task Instance's ``log_url`` (#39183) +- Improve task filtering ``UX`` (#39119) +- Improve rendered_template ``ux`` in react dag page (#39122) +- Graph view improvements (#38940) +- Check that the dataset<>task exists before trying to render graph (#39069) +- Hostname was "redacted", not "redact"; remove it when there is no context (#39037) +- Check whether ``AUTH_ROLE_PUBLIC`` is set in ``check_authentication`` (#39012) +- Move rendering of ``map_index_template`` so it renders for failed tasks as long as it was defined before the point of failure (#38902) +- ``Undeprecate`` ``BaseXCom.get_one`` method for now (#38991) +- Add ``inherit_cache`` attribute for ``CreateTableAs`` custom SA Clause (#38985) +- Don't wait for DagRun lock in mini scheduler (#38914) +- Fix calendar view with no DAG Run. (#38964) Review Comment: ```suggestion - Fix calendar view with no DAG Run (#38964) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
