jedcunningham commented on code in PR #39312:
URL: https://github.com/apache/airflow/pull/39312#discussion_r1583879860
##########
docs/exts/includes/sections-and-options.rst:
##########
@@ -63,13 +63,13 @@
:Default: ``{{ "''" if option["default"] == "" else option["default"] }}``
{% if option.get("sensitive") %}
:Environment Variables:
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}``
Review Comment:
```suggestion
``AIRFLOW__{{ section_name | replace(".", "_") | upper }}__{{
option_name | upper }}``
```
Let's add a space in there.
##########
docs/exts/includes/sections-and-options.rst:
##########
@@ -63,13 +63,13 @@
:Default: ``{{ "''" if option["default"] == "" else option["default"] }}``
{% if option.get("sensitive") %}
:Environment Variables:
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}``
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}_CMD``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}_CMD``
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}_SECRET``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}_SECRET``
Review Comment:
```suggestion
``AIRFLOW__{{ section_name | replace(".", "_") | upper }}__{{
option_name | upper }}_SECRET``
```
##########
docs/exts/includes/sections-and-options.rst:
##########
@@ -63,13 +63,13 @@
:Default: ``{{ "''" if option["default"] == "" else option["default"] }}``
{% if option.get("sensitive") %}
:Environment Variables:
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}``
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}_CMD``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}_CMD``
Review Comment:
```suggestion
``AIRFLOW__{{ section_name | replace(".", "_") | upper }}__{{
option_name | upper }}_CMD``
```
##########
docs/exts/includes/sections-and-options.rst:
##########
@@ -63,13 +63,13 @@
:Default: ``{{ "''" if option["default"] == "" else option["default"] }}``
{% if option.get("sensitive") %}
:Environment Variables:
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}``
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}_CMD``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}_CMD``
- ``AIRFLOW__{{ section_name | upper }}__{{ option_name | upper }}_SECRET``
+ ``AIRFLOW__{{ section_name | replace(".","_") | upper }}__{{ option_name
| upper }}_SECRET``
{% else %}
- :Environment Variable: ``AIRFLOW__{{ section_name | upper }}__{{
option_name | upper }}``
+ :Environment Variable: ``AIRFLOW__{{ section_name | replace(".","_") |
upper }}__{{ option_name | upper }}``
Review Comment:
```suggestion
:Environment Variable: ``AIRFLOW__{{ section_name | replace(".", "_") |
upper }}__{{ option_name | upper }}``
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
