goodseeyou commented on code in PR #39303:
URL: https://github.com/apache/airflow/pull/39303#discussion_r1584101888


##########
scripts/docker/clean-logs.sh:
##########
@@ -32,7 +33,7 @@ while true; do
   echo "Trimming airflow logs to ${RETENTION} days."
   find "${DIRECTORY}"/logs \
     -type d -name 'lost+found' -prune -o \
-    -type f -mtime +"${RETENTION}" -name '*.log' -print0 | \
+    -type f -mtime -"${ABS_RETENTION}" -name '*.log' -print0 | \

Review Comment:
   > The existing behavior is changed. we usually look for the files for which 
are not modified since x days. This is not matching with the given expression.
   
   Original script will ask to give `-x` day, or it will not work. After my 
change, no matter given x day or -x day, the script will find the files which 
are not modified since |x| days ago.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to