Lee-W commented on issue #38028:
URL: https://github.com/apache/airflow/issues/38028#issuecomment-2084766197

   > I'd love guidance on how to make the logic in 
`CloudRunExecuteJobOperator._fail_if_execution_failed` shared between 
`CloudRunExecuteJobOperator` and `CloudRunJobFinishedTrigger`.
   
   I think we'll need to find out a way to [get 
result](https://github.com/apache/airflow/blob/e979eccf63bcc3757681a17376d101a62e7d87cf/airflow/providers/google/cloud/operators/cloud_run.py#L352)
 in async manner. Rest of the logic should be the same as [sync 
mode](https://github.com/apache/airflow/blob/e979eccf63bcc3757681a17376d101a62e7d87cf/airflow/providers/google/cloud/operators/cloud_run.py#L340-L348).
 I guess the logic will be added somewhere around 
https://github.com/apache/airflow/blob/e979eccf63bcc3757681a17376d101a62e7d87cf/airflow/providers/google/cloud/triggers/cloud_run.py#L106-L107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to