o-nikolas commented on code in PR #39212:
URL: https://github.com/apache/airflow/pull/39212#discussion_r1585076323
##########
airflow/providers/celery/executors/celery_executor.py:
##########
@@ -368,8 +368,10 @@ def update_all_task_states(self) -> None:
if state:
self.update_task_state(key, state, info)
- def change_state(self, key: TaskInstanceKey, state: TaskInstanceState,
info=None) -> None:
- super().change_state(key, state, info)
+ def change_state(
+ self, key: TaskInstanceKey, state: TaskInstanceState, info=None,
remove_running=True
+ ) -> None:
+ super().change_state(key, state, info, remove_running=remove_running)
Review Comment:
This is actually using the default and just plumbing it through, it was to
make the static checks happy because they compare the stub against the super
class. I'm not sure the best way to get around this one. Perhaps just no-qa,
since it's actually fine and desirable to just use the default here, no real
need to plumb it through.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
