tatiana opened a new pull request, #39366:
URL: https://github.com/apache/airflow/pull/39366

   Since the change https://github.com/apache/airflow/pull/38033 was merged, 
`airflow-providers-dbt-cloud>=1.7.0` depends on 
`airflow-providers-openlineage>=1.7.0` if OpenLineage is used.
   
   If users attempt to use `airflow-providers-dbt-cloud>=1.7.0` and 
`airflow-providers-openlineage<1.7.0` with OpenLineage enabled, they will face 
the error:
   ```
   2024-05-01, 10:17:39 UTC] {base.py:147} ERROR - OpenLineage provider method 
failed to import OpenLineage integration. This should not happen.
   Traceback (most recent call last):
     File 
/usr/local/lib/python3.9/site-packages/airflow/providers/openlineage/extractors/base.py,
 line 137, in _get_openlineage_facets
       facets: OperatorLineage = get_facets_method(*args)
     File 
/usr/local/lib/python3.9/site-packages/airflow/providers/dbt/cloud/operators/dbt.py,
 line 249, in get_openlineage_facets_on_complete
       return generate_openlineage_events_from_dbt_cloud_run(operator=self, 
task_instance=task_instance)
     File 
/usr/local/lib/python3.9/site-packages/airflow/providers/dbt/cloud/utils/openlineage.py,
 line 50, in generate_openlineage_events_from_dbt_cloud_run
       from airflow.providers.openlineage.conf import namespace
   ModuleNotFoundError: No module named 'airflow.providers.openlineage.conf'
   ```
   
   Given that the dependency between both is optional, this PR introduces 
additional extras to the dbt provider, solving the dependency issue for users 
who install using it using: `airflow-providers-dbt-cloud[openlineage]`.
   
   <!--
    Licensed to the Apache Software Foundation (ASF) under one
    or more contributor license agreements.  See the NOTICE file
    distributed with this work for additional information
    regarding copyright ownership.  The ASF licenses this file
    to you under the Apache License, Version 2.0 (the
    "License"); you may not use this file except in compliance
    with the License.  You may obtain a copy of the License at
   
      http://www.apache.org/licenses/LICENSE-2.0
   
    Unless required by applicable law or agreed to in writing,
    software distributed under the License is distributed on an
    "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    KIND, either express or implied.  See the License for the
    specific language governing permissions and limitations
    under the License.
    -->
   
   <!--
   Thank you for contributing! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   In case of an existing issue, reference it using one of the following:
   
   closes: #ISSUE
   related: #ISSUE
   
   How to write a good git commit message:
   http://chris.beams.io/posts/git-commit/
   -->
   
   
   
   <!-- Please keep an empty line above the dashes. -->
   ---
   **^ Add meaningful description above**
   Read the **[Pull Request 
Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)**
 for more information.
   In case of fundamental code changes, an Airflow Improvement Proposal 
([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals))
 is needed.
   In case of a new dependency, check compliance with the [ASF 3rd Party 
License Policy](https://www.apache.org/legal/resolved.html#category-x).
   In case of backwards incompatible changes please leave a note in a 
newsfragment file, named `{pr_number}.significant.rst` or 
`{issue_number}.significant.rst`, in 
[newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to