dondaum commented on PR #39299: URL: https://github.com/apache/airflow/pull/39299#issuecomment-2092462804
Yes legacy backrefs should be replaced anyway by `back_populates` and explicit relationships. Yet we will still see those warnings as also with `back_populates` and an explicit relationship SQLAlchlemy 1.4 still uses the old way of merging an object into the Session along the cascade path. Just to make sure, we can fix all _object is being merged into a Session along the backref cascade path_ with the current setup (NOT setting future=True in the Session object) when we - create the object first, - adding it then to the session and - adding afterwards the relationship values where backref/back_populates is happening. Similar to [here](https://github.com/apache/airflow/pull/39299#issuecomment-2089195859). IMO it will still be less readable and unstandable. It is also just a warning that does not lead to false behavior when handled correctly. And you can confirm it by using `future=True` in the Session WDYT? Shall I change it in a way that all warnings are fixed or shall we acknowledge some warnings as False positives ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
