shubham22 commented on issue #22006:
URL: https://github.com/apache/airflow/issues/22006#issuecomment-2092464893

   I agree with @jscheffl here that this use case doesn't warrant adding a new 
state with paused/unpaused/drain for DAGs as it will complicate and slow down 
scheduling (and rescheduling) logic. We could do this as UI-only feature, but I 
am personally not convinced that we need to handle this edge case. If we really 
really need to, I think it is better to provide single and consistent behaviour 
for pausing DAGs, which considers drainage, unlike today. 
   
   > If one is able to 'disable' the schedule on a DAG, the 'drain' 
functionality can be achieved without having to make changes to the is_paused 
field.
   
   @SangwanP - the use case that you started with was primarily focused on 
version upgrades and in that scenario, you only need this at the environment 
level, not at a DAG level. Moreover, in my experience, if you're doing an 
in-place version upgrade, any tasks that are scheduled, but not yet finished 
will be run again once version is upgraded. I don't think it is required for 
you to set all schedules to _none_ and re-set them. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to