Taragolis commented on code in PR #39418:
URL: https://github.com/apache/airflow/pull/39418#discussion_r1590308109
##########
airflow/migrations/versions/0093_2_2_0_taskinstance_keyed_to_dagrun.py:
##########
@@ -225,8 +225,7 @@ def upgrade():
constraints = get_mssql_table_constraints(conn,
"task_instance")
pk, _ = constraints["PRIMARY KEY"].popitem()
batch_op.drop_constraint(pk, type_="primary")
- elif dialect_name not in ("sqlite"):
- batch_op.drop_constraint("task_instance_pkey", type_="primary")
+ batch_op.drop_constraint("task_instance_pkey", type_="primary")
Review Comment:
```json
{
"category": "sqlalchemy.exc.SAWarning",
"message": "Table '_alembic_tmp_task_instance' specifies columns
'task_id', 'dag_id' as primary_key=True, not matching locally specified columns
'dag_id', 'task_id', 'run_id'; setting the current primary key columns to
'dag_id', 'task_id', 'run_id'. This warning may become an exception in a future
release",
"filename": "/usr/local/lib/python3.8/contextlib.py",
"lineno": 120,
"when": "runtest",
"node_id": "tests/www/test_app.py::TestApp::test_should_respect_proxy_fix",
"group": "other",
"count": 1
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
