thesuperzapper commented on issue #36090: URL: https://github.com/apache/airflow/issues/36090#issuecomment-2096716595
For those watching, I have done a little more testing with the workaround proposed in https://github.com/apache/airflow/issues/36090#issuecomment-2094972855, and at least in my tests, it works correctly when `execution_timeout` or `defer(timeout=xxxx)` is reached. That is, the `self.safe_to_cancel()` returns true, and the external job is canceled (because the TaskInstance becomes `failed` status before terminating the deferred operator). But I would be surprised if there was not some race condition involving timeouts, so more testing is needed. However, my preference is still finding a way to make `on_kill` run even when the task is deferred, even if only so that we don't have to tell everyone to update their providers! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
