ashb commented on a change in pull request #5979: [AIRFLOW-5373] Super fast
pre-commit check for basic python2 compatib…
URL: https://github.com/apache/airflow/pull/5979#discussion_r320254712
##########
File path: airflow/contrib/example_dags/example_qubole_operator.py
##########
@@ -198,7 +198,7 @@ def compare_result(ds, **kwargs):
/** Computes an approximation to pi */
object SparkPi {
- def main(args: Array[String]) {
+ def main(args) {
Review comment:
Looks like https://pre-commit.com/#regular-expressions to exclude the whole
file is the only way to do this one. A bit overly broad but this file isn't
changed very often so that's probably okay. That or adjust the regex to not
allow `) {` on the line (trickier regex to get that working)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
