Taragolis commented on code in PR #39420:
URL: https://github.com/apache/airflow/pull/39420#discussion_r1592084699
##########
airflow/providers/docker/decorators/docker.py:
##########
@@ -128,9 +190,15 @@ def execute(self, context: Context):
@property
def pickling_library(self):
Review Comment:
[`ModuleType`](https://docs.python.org/3/library/types.html#types.ModuleType)
exists for build module dynamically, it not make a sense to use it for type
annotations.
What the point here to have it rather than `Any` / `object` here? What
benefits it would granted?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]