MaksYermak commented on code in PR #39201:
URL: https://github.com/apache/airflow/pull/39201#discussion_r1592404990
##########
airflow/providers/cncf/kubernetes/hooks/kubernetes.py:
##########
@@ -486,6 +488,12 @@ def get_deployment_status(
except Exception as exc:
raise exc
+ @tenacity.retry(
Review Comment:
The idea was to retry HTTP request to Kubernetes when Kubernetes returns `No
agent available` error. This issue is inside Kubernetes and appears time to
time. I know that this error has 500 code which, also, code for non-transient
errors. I do not see any problems for non-transient errors because the code
will try to retry request only 3 times. If users have non-transient errors,
after the third attempt they will see an exception.
As for relying on task retry. I think it's not a good idea to retry the
whole task because of a temporary problem with HTTP request.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
