mik-laj commented on a change in pull request #5944: [AIRFLOW-5362] Reorder
imports
URL: https://github.com/apache/airflow/pull/5944#discussion_r320272748
##########
File path: airflow/_vendor/nvd3/__init__.py
##########
@@ -16,14 +16,14 @@
'scatterChart', 'discreteBarChart', 'multiBarChart']
+from . import ipynb
+from .cumulativeLineChart import cumulativeLineChart
Review comment:
I think that this change should be combined with automatic code formatting.
Some automatic formatting tools also sort imports. If we now introduce import
sorting, we will limit the choice of a tool that will be compatible, or we will
have to re-sort all imports this time in a manner compatible with another tool.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
