jedcunningham commented on code in PR #38841:
URL: https://github.com/apache/airflow/pull/38841#discussion_r1594308894
##########
chart/templates/_helpers.yaml:
##########
@@ -223,27 +223,28 @@ If release name contains chart name it will be used as a
full name.
- name: GITSYNC_SSH_KNOWN_HOSTS
value: "false"
{{- end }}
- {{ else if .Values.dags.gitSync.credentialsSecret }}
- - name: GIT_SYNC_USERNAME
+ {{- else if and .Values.dags.gitSync.credentialsSecret (semverCompare
">=v4.0.0" .Values.images.gitSync.tag)}}
Review Comment:
We can't rely on the tag to determine the version, unfortunately. Someone
could easily mirror the image and change the tagging approach (e.g.
`2024-05-08`).
If we need to do it conditionally, we need to introduce another version
config like we have for `airflowVersion`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
