jedcunningham commented on code in PR #39497: URL: https://github.com/apache/airflow/pull/39497#discussion_r1594570487
########## airflow/providers/alibaba/__init__.py: ########## @@ -29,10 +29,7 @@ __version__ = "2.8.0" -try: - from airflow import __version__ as airflow_version -except ImportError: - from airflow.version import version as airflow_version +from airflow import __version__ as airflow_version Review Comment: Good call, thanks. Note I didn't import `version` as I thought having a str `__version__` and a method `version` that comes from importlib felt a bit weird. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
