Xiroo commented on code in PR #38697:
URL: https://github.com/apache/airflow/pull/38697#discussion_r1595036924
##########
chart/templates/statsd/statsd-deployment.yaml:
##########
@@ -104,8 +104,17 @@ spec:
- "--statsd.mapping-config=/etc/statsd-exporter/mappings.yml"
{{- end }}
resources: {{- toYaml .Values.statsd.resources | nindent 12 }}
- {{- with .Values.statsd.env }}
- env: {{- toYaml . | nindent 12 }}
+ env:
+ {{- if .Values.statsd.env }}
+ {{- toYaml .Values.statsd.env | nindent 12 }}
+ {{- end }}
+ {{- if .Values.config.metrics.metrics_allow_list }}
+ - name: AIRFLOW__METRICS__METRICS_ALLOW_LIST
Review Comment:
Thank you for your advice.
Then, I'm wondering is it bad idea adding a default TTL value here, aimed at
ensuring they expire after a specified period of no updates.
I think it is distracting if metrics are not expired after changing
metrics_allow_list and metrics_block_list so it is needed for others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
