potiuk commented on PR #39528: URL: https://github.com/apache/airflow/pull/39528#issuecomment-2103254550
> Should we add the xmlsec pin there also? :shrug: :) I am not even sure while libxmlsec1 in the image was needed in the first place :). It's been added specifically on request by @vincbeck (I remember I helped to explain how to add it) - but I have no idea why it was needed at all (possibly for System Tests to run with AWS Executor) https://github.com/apache/airflow/pull/35488 - that's why when we encountered failing main I added the limit to fix it and left the issue to investigate, but to be perfectly honest, I have no slightest idea what are consequences of leaving it in/adding limit saml extra :scream: All I know that 3 weeks ago - until I added xmlsec<1.3.14 - it broke main with error - xmlsec 1.3.14 started to complained that it needs libxmlsec1.2+ if you look at the release notes: https://github.com/xmlsec/python-xmlsec/releases - 1.3.14 has a change "Improved libxml2 version check" - which is this change: https://github.com/xmlsec/python-xmlsec/pull/299/files and our CI builds started to fail with `lxml & xmlsec libxml2 library version mismatch`. That's all I know about it :). That's why I am surprised we do not see that error in this PR (despite evidently 1.3.14 being installed as you can see in generated constraints output. I cannot see the original failure - it's gone as action logs are kept for 2 weeks, so my guts feeling tells me it will start failing our main again after merging, but let's see. That's all I know about it. Maybe @vincbeck could explain why we needed to add `libxmlsec1 to our image at all ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
