potiuk commented on code in PR #39513: URL: https://github.com/apache/airflow/pull/39513#discussion_r1596005178
########## tests/providers/openlineage/plugins/test_listener.py: ########## @@ -33,10 +33,20 @@ from airflow.providers.openlineage.plugins.listener import OpenLineageListener from airflow.providers.openlineage.utils.selective_enable import disable_lineage, enable_lineage from airflow.utils.state import State +from tests.test_utils.compat import AIRFLOW_V_2_10_PLUS from tests.test_utils.config import conf_vars pytestmark = pytest.mark.db_test +EXPECTED_TRY_NUMBER_1 = 1 if AIRFLOW_V_2_10_PLUS else 0 Review Comment: @mobuchowski @kacpermuda @dstandish -> this was the easiest way I found to make the same tests work before and after the try_num change. I am not sure if this is the **right** or **easy** way to do it, and what's the reasoning behind having those tests, but certainly it looks like with the `try_num` changes, the values that open-lineage listener will receive will change - the tests now work for both pre- and post- `try_num` change. I basically have two questions: * is it ok to keep it this way? (@dstandish ?) * does it not mean that open-lineage integration for Airlfow 2.10 is heavily impacted by the `try_num` change (@mobuchowski , @kacpermuda ) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscr...@airflow.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
