dondaum commented on code in PR #39293:
URL: https://github.com/apache/airflow/pull/39293#discussion_r1596020683


##########
airflow/providers/fab/auth_manager/security_manager/override.py:
##########
@@ -1506,14 +1506,15 @@ def add_user(
             user.username = username
             user.email = email
             user.active = True
+            self.get_session.add(user)

Review Comment:
   As we discussed 
[here](https://github.com/apache/airflow/pull/39299#issuecomment-2092597149) we 
try to fix all warnings. So IMO this change looks good.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to