kaxil commented on code in PR #39510:
URL: https://github.com/apache/airflow/pull/39510#discussion_r1596031307
##########
airflow/settings.py:
##########
@@ -666,3 +666,7 @@ def initialize():
"y",
"1",
}
+
+IS_SCARF_ANALYTICS_ENABLED = conf.getboolean("scarf_analytics", "enabled",
fallback=True) and (
Review Comment:
added in
https://github.com/apache/airflow/pull/39510/commits/33ceb8cd05dc5832f0602870b01ae5d810c2cefd
##########
airflow/settings.py:
##########
@@ -666,3 +666,7 @@ def initialize():
"y",
"1",
}
+
+IS_SCARF_ANALYTICS_ENABLED = conf.getboolean("scarf_analytics", "enabled",
fallback=True) and (
Review Comment:
~Since this is a variable like other vars that gets initialized as soon as
"airflow" is imported, this is difficult to test. I would need to convert it to
a function -- but I think this is trivial.~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
