uranusjr commented on code in PR #39513:
URL: https://github.com/apache/airflow/pull/39513#discussion_r1599601480
##########
dev/breeze/src/airflow_breeze/utils/selective_checks.py:
##########
@@ -816,6 +818,15 @@ def parallel_test_types_list_as_string(self) -> str | None:
self._extract_long_provider_tests(current_test_types)
return " ".join(sorted(current_test_types))
+ @cached_property
+ def providers_test_types_list_as_string(self) -> str | None:
+ all_test_types = self.parallel_test_types_list_as_string
+ if all_test_types is None:
+ return None
+ return " ".join(
+ [test_type for test_type in all_test_types.split(" ") if
test_type.startswith("Providers")]
+ )
Review Comment:
```suggestion
return " ".join(
test_type for test_type in all_test_types.split(" ") if
test_type.startswith("Providers")
)
```
##########
tests/conftest.py:
##########
@@ -1292,6 +1296,19 @@ def _disable_redact(request: pytest.FixtureRequest,
mocker):
return
[email protected]
+def airflow_root_path() -> Path:
+ import airflow
+
+ return Path(airflow.__path__[0]).parent
+
+
[email protected]
+def require_running_tests_from_sources() -> None:
+ if not (Path(__file__).parents[1] / "airflow" / "__init__.py").exists():
+ pytest.skip("This test requires tests to be run from sources. Skipping
it")
Review Comment:
This should be replaced with a `skipif` marker instead.
https://doc.pytest.org/en/latest/reference/reference.html#pytest-mark-skipif-ref
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]