MaksYermak commented on code in PR #39371:
URL: https://github.com/apache/airflow/pull/39371#discussion_r1599729072
##########
airflow/providers/apache/beam/triggers/beam.py:
##########
@@ -233,6 +235,22 @@ async def run(self) -> AsyncIterator[TriggerEvent]: #
type: ignore[override]
if is_running:
await asyncio.sleep(self.poll_sleep)
try:
+ # Creating a new event loop to manage I/O operations asynchronously
Review Comment:
@potiuk @Lee-W I have checked. We can't get rid of `event_loop` here,
because as I understand it's only one option to execute a synchronous method in
async code. Also we can't change this method to async, because google does not
have async client for this method. But we can change `get_event_loop` to
`get_running_loop` for improving code quality. I will do it in the next commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
