pankajkoti commented on code in PR #39526: URL: https://github.com/apache/airflow/pull/39526#discussion_r1600556034
########## airflow/migrations/versions/0143_2_9_2_add_index_on_dag_id_in_referencing_tables.py: ########## @@ -0,0 +1,69 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +"""Add index on dag_id in referencing tables. + +Revision ID: 250a7e04585c +Revises: 686269002441 +Create Date: 2024-05-09 19:18:54.028277 + +""" + +from __future__ import annotations + +from alembic import op + +# revision identifiers, used by Alembic. +revision = "250a7e04585c" +down_revision = "686269002441" +branch_labels = None +depends_on = None +airflow_version = "2.9.2" + + +def upgrade(): + """Apply Add index on dag_id in referencing tables.""" + conn = op.get_bind() + # MySQL already indexes the foreign keys, hence only create indexes for postgres and sqlite. + if conn.dialect.name in ("postgresql", "sqlite"): Review Comment: Curious if you are suggesting this because of the failing test? I do not find such a reference in our previous migrations. I am guessing the mismatch is because we're adding the Index in the SQLAlchemy models but it's not necessary for MySQL since they are created by default. I tried removing it from the model and having it just in the migrations. With that it succeeds for MySQL, but then complains for PostgreSQL and SQLite about the mismatch between db schema and SQLAlchemy models. @ephraimbuddy would you have some inputs for me here based on your previous migrations expertise :) ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
