Taragolis commented on code in PR #39217: URL: https://github.com/apache/airflow/pull/39217#discussion_r1602976720
########## airflow/providers/teradata/transfers/s3_to_teradata.py: ########## @@ -0,0 +1,100 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +from __future__ import annotations + +from typing import TYPE_CHECKING, Sequence + +from airflow.models import BaseOperator +from airflow.providers.amazon.aws.hooks.s3 import S3Hook +from airflow.providers.teradata.hooks.teradata import TeradataHook + +if TYPE_CHECKING: + from airflow.utils.context import Context + + +class S3ToTeradataOperator(BaseOperator): + """ + Loads CSV, JSON and Parquet format data from Amazon S3 to Teradata. + + .. seealso:: + For more information on how to use this operator, take a look at the guide: + :ref:`howto/operator:S3ToTeradataOperator` + + :param s3_source_key: The URI format specifying the location of the S3 object store.(templated) + The URI format is /s3/YOUR-BUCKET.s3.amazonaws.com/YOUR-BUCKET-NAME. + Refer to + https://docs.teradata.com/search/documents?query=native+object+store&sort=last_update&virtual-field=title_only&content-lang=en-US + :param teradata_table: The name of the teradata table to which the data is transferred.(templated) + :param aws_conn_id: The Airflow AWS connection used for AWS credentials. + :param teradata_conn_id: The connection ID used to connect to Teradata + :ref:`Teradata connection <howto/connection:Teradata>`. + + Note that ``s3_source_key`` and ``teradata_table`` are + templated, so you can use variables in them if you wish. + """ + + template_fields: Sequence[str] = ("s3_source_key", "teradata_table") + ui_color = "#e07c24" + + def __init__( + self, + *, + s3_source_key: str, + teradata_table: str, + aws_conn_id: str = "aws_default", + teradata_conn_id: str = "teradata_default", + **kwargs, + ) -> None: + super().__init__(**kwargs) + self.s3_source_key = s3_source_key + self.teradata_table = teradata_table + self.aws_conn_id = aws_conn_id + self.teradata_conn_id = teradata_conn_id + + def execute(self, context: Context) -> None: + self.log.info( + "transferring data from %s to teradata table %s...", self.s3_source_key, self.teradata_table + ) + + s3_hook = S3Hook(aws_conn_id=self.aws_conn_id) + access_key = ( + s3_hook.conn_config.aws_access_key_id if s3_hook.conn_config.aws_access_key_id is not None else "" + ) + access_secret = ( + s3_hook.conn_config.aws_secret_access_key + if s3_hook.conn_config.aws_secret_access_key is not None + else "" + ) Review Comment: > Concerning the STS session token, we had a JIRA task pending to integrate Teradata authorization object as a parameter for cloud transfer operators. I would recommend to add into the Operator documentation about current limitation ``` .. note:: Fo Bar Spam Egg ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
