dirrao commented on code in PR #39652:
URL: https://github.com/apache/airflow/pull/39652#discussion_r1603240751
##########
airflow/models/connection.py:
##########
@@ -271,12 +271,6 @@ def _create_host(protocol, host) -> str | None:
def get_uri(self) -> str:
"""Return connection in URI format."""
- if self.conn_type and "_" in self.conn_type:
Review Comment:
Congratulations on you first PR.
I believe this is still needed. Let't wait for others comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]