dstandish commented on PR #38549: URL: https://github.com/apache/airflow/pull/38549#issuecomment-2118632135
> Let's prefix with `_`, or maybe `_aip44RpcServer`? I'm hesitant of a docs only change. Did it. Went with `_rpcServer`. I think that's definitely clear enough. When we make it "public" then we'll have to change it both at top level and in .Values.ports._rpcServer. But that should be easy to catch since it will show up in a find / replace. I think this is should be ready to go now, presuming tests pass now, especially now that we made it "private". I added comments and newsfragment. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
