jscheffl commented on issue #39471: URL: https://github.com/apache/airflow/issues/39471#issuecomment-2119272806
Note that when I contributed this I had some challenges because of JavaScript security. From outside the log panel it was somehow (don't know why) not possible to directly set all details, especially events on the DOM of the logs. So I don't know if a "toggle all" is simple. But might be a feature. One comment for the desire to remove time stamps: Grouping is made based on logs which itself have time stamps. If you see it visual it might be important knowing when the group was made, if no other log statements immediately follow with a time stamp. The grouping message by itself might be standing along. Therefore I kept the timestamps by intent not to lose information. Also I by intent left the end of the group as a line, else if you remove this you visually don't see anymore in the log text where the group actually ends. If there is a group following the other it might be clear, otherwise if a group ends and other log lines continue you can not associate which content was belonging to the group. I'd propose to keep a visual signal what content is grouped as the grouping script does not carry an animation and just hides. If you want to remove the line with the end, please consider any kind or alternative highlight or marker to show where the end of the group is. Note: As working with Airflow and Github I needed to realize that the log loading of Github is really painful and slow, Airflow log loading is fast in the browser. Also Github does not allow nested groups (groups in groups) which the current solution allows... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
