Re: [PR] Home: filter running/failed and active/paused dags [airflow]

Mon, 20 May 2024 09:15:23 -0700 


bbovenzi commented on PR #39701:
URL: https://github.com/apache/airflow/pull/39701#issuecomment-2120769740

   > > Might it be cleaner to just unselect failed? There are only two buttons, 
so I don't know that it makes sense to include an "all states" button when 
there are only two states to choose from.
   > 
   > I liked the idea, so I implemented it. Now it looks like the current 
version:
   > 
   > <img alt="image" width="608" 
src="https://private-user-images.githubusercontent.com/41503039/331811987-eecaf545-6725-4681-8679-b3900b4357ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTYyMjE5MDEsIm5iZiI6MTcxNjIyMTYwMSwicGF0aCI6Ii80MTUwMzAzOS8zMzE4MTE5ODctZWVjYWY1NDUtNjcyNS00NjgxLTg2NzktYjM5MDBiNDM1N2FjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTIwVDE2MTMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzZmViZTMwZDJlMTBlNzBkYmJjOGFiMDljNTUwMjFhMmJkNjRhODc3OWM0NjNkZDBmNDg1ZWJlNmFiYjFiMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lv9tGaJmWnewaRjq4I1TR9EEvfgubCvpu12iyX0wv1A";>
   
   
   
   > > Might it be cleaner to just unselect failed? There are only two buttons, 
so I don't know that it makes sense to include an "all states" button when 
there are only two states to choose from.
   > 
   > I liked the idea, so I implemented it. Now it looks like the current 
version:
   > 
   > <img alt="image" width="608" 
src="https://private-user-images.githubusercontent.com/41503039/331811987-eecaf545-6725-4681-8679-b3900b4357ac.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTYyMjE5MDEsIm5iZiI6MTcxNjIyMTYwMSwicGF0aCI6Ii80MTUwMzAzOS8zMzE4MTE5ODctZWVjYWY1NDUtNjcyNS00NjgxLTg2NzktYjM5MDBiNDM1N2FjLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA1MjAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNTIwVDE2MTMyMVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTkzZmViZTMwZDJlMTBlNzBkYmJjOGFiMDljNTUwMjFhMmJkNjRhODc3OWM0NjNkZDBmNDg1ZWJlNmFiYjFiMGImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.lv9tGaJmWnewaRjq4I1TR9EEvfgubCvpu12iyX0wv1A";>
   
   I like this. Let's get rid of the `?lastrun=all_states` param, that should 
be the default when nothing is specified.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to