MaksYermak commented on code in PR #39727:
URL: https://github.com/apache/airflow/pull/39727#discussion_r1608215244
##########
tests/always/test_example_dags.py:
##########
@@ -56,11 +56,11 @@
"tests/system/providers/google/cloud/dataproc/example_dataproc_gke.py",
"tests/system/providers/google/cloud/gcs/example_gcs_sensor.py",
"tests/system/providers/google/cloud/gcs/example_gcs_to_gcs.py",
-
"tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine.py",
-
"tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py",
-
"tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_job.py",
-
"tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_kueue.py",
-
"tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_resource.py",
+ #
"tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine.py",
Review Comment:
Why did you comment these rows rather than remove them?
##########
tests/system/providers/google/cloud/kubernetes_engine/example_kubernetes_engine_async.py:
##########
@@ -40,7 +40,12 @@
GCP_LOCATION = "europe-north1-a"
CLUSTER_NAME = f"gke-async-{ENV_ID}".replace("_", "-")
-CLUSTER = {"name": CLUSTER_NAME, "initial_node_count": 1}
+CLUSTER = {
+ "name": CLUSTER_NAME,
+ "node_pools": {
+ "initial_node_count": 1,
+ },
Review Comment:
Did you try to run these tests with this configuration in your local
environment?
Because I have an error when I try to run tests with this configuration:
`google.protobuf.json_format.ParseError: Failed to parse node_pools field:
repeated field node_pools must be in [] which is {'initial_node_count': 1} at
Cluster.
`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
