VladaZakharova commented on code in PR #39713:
URL: https://github.com/apache/airflow/pull/39713#discussion_r1608449403
##########
tests/system/providers/google/cloud/bigquery/example_bigquery_sensors.py:
##########
@@ -138,12 +137,13 @@
# [END howto_sensor_bigquery_table_partition_defered]
# [START howto_sensor_bigquery_table_partition_async]
- check_table_partition_exists_async =
BigQueryTableExistencePartitionAsyncSensor(
+ check_table_partition_exists_async = BigQueryTablePartitionExistenceSensor(
Review Comment:
The same here, we can just remove this one
##########
tests/system/providers/google/cloud/bigquery/example_bigquery_sensors.py:
##########
@@ -98,11 +96,12 @@
# [END howto_sensor_bigquery_table_defered]
# [START howto_sensor_async_bigquery_table]
- check_table_exists_async = BigQueryTableExistenceAsyncSensor(
+ check_table_exists_async = BigQueryTableExistenceSensor(
Review Comment:
There is already the same task, that is called check_table_exists_def which
is doing the same. I think there is no need to duplicate tasks and we can just
remove this one
##########
tests/system/providers/google/cloud/gcs/example_gcs_sensor.py:
##########
@@ -141,10 +140,11 @@ def mode_setter(self, value):
# [END howto_sensor_object_exists_task]
# [START howto_sensor_object_exists_task_async]
- gcs_object_exists_async = GCSObjectExistenceAsyncSensor(
+ gcs_object_exists_async = GCSObjectExistenceSensor(
Review Comment:
The same here.
Also, if we are updating examples here (removing tasks), please make sure
that changes in gcs.rst file are the same - the howto tags should have specific
name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
