potiuk commented on code in PR #39723:
URL: https://github.com/apache/airflow/pull/39723#discussion_r1609155270
##########
hatch_build.py:
##########
@@ -846,6 +846,17 @@ def initialize(self, version: str, build_data: dict[str,
Any]) -> None:
# field in core.metadata until this is possible
self.metadata.core._optional_dependencies = self.optional_dependencies
+ # Add entrypoints dynamically for all provider packages, else they
will not be found by
Review Comment:
Looks cool. The only thing is that `entrypoints` should be defined in
`dynamic` array in pyproject.toml, otherwise, frontends will not know that they
are available (pip might still read them regardless but technically speaking it
is required:
https://peps.python.org/pep-0621/#dynamic
> If the metadata does not list a field in dynamic, then a build back-end
CANNOT fill in the requisite metadata on behalf of the user (i.e. dynamic is
the only way to allow a tool to fill in metadata and the user must opt into the
filling in).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
