eladkal commented on code in PR #39747:
URL: https://github.com/apache/airflow/pull/39747#discussion_r1609214576


##########
Dockerfile.ci:
##########
@@ -1005,8 +1005,12 @@ function check_boto_upgrade() {
     ${PACKAGING_TOOL_CMD} uninstall ${EXTRA_UNINSTALL_FLAGS} aiobotocore s3fs 
|| true
     # We need to include oss2 as dependency as otherwise jmespath will be 
bumped and it will not pass
     # the pip check test, Similarly gcloud-aio-auth limit is needed to be 
included as it bumps cryptography
+    # Also until docker-py compatibility with requests 2.32 is fixed we need 
to limit requests version
+    # Should be removed after  https://github.com/docker/docker-py/issues/3256 
together with removal of similar
+    # limitation in providers/docker/pyproject.toml
     # shellcheck disable=SC2086
-    ${PACKAGING_TOOL_CMD} install ${EXTRA_INSTALL_FLAGS} --upgrade boto3 
botocore "oss2>=2.14.0" "gcloud-aio-auth>=4.0.0,<5.0.0"
+    ${PACKAGING_TOOL_CMD} install ${EXTRA_INSTALL_FLAGS} --upgrade boto3 
botocore \
+       "oss2>=2.14.0" "gcloud-aio-auth>=4.0.0,<5.0.0" "requests<2.32.0"

Review Comment:
   Requests released new version, so I think we can bump to requests>2.32.0
   However we also need to wait for docker-py to release new version



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to