Taragolis commented on code in PR #39743:
URL: https://github.com/apache/airflow/pull/39743#discussion_r1609455208


##########
tests/system/providers/amazon/aws/example_emr.py:
##########
@@ -143,6 +143,7 @@ def get_step_id(step_ids: list):
     create_job_flow = EmrCreateJobFlowOperator(
         task_id="create_job_flow",
         job_flow_overrides=JOB_FLOW_OVERRIDES,
+        waiter_delay=60

Review Comment:
   If user do not provide anything than some EMR operators raise 
`AirflowProviderDeprecationWarning`, which I guess should not be a case.
   
   `waiter_max_attempts` and `waiter_delay` are arguments which replace 
`waiter_countdown` and `waiter_check_interval_seconds`, however 
`waiter_max_attempts` and `waiter_delay` has None as default as well as 
`waiter_countdown`, however deprecated `waiter_check_interval_seconds` has 
default value which resulted to raise `AirflowProviderDeprecationWarning` 
warning unless user explicitly not set it to `None`
   
   
https://github.com/apache/airflow/blob/830b71b3be66b970340e85cb8f4a297625c71ea1/airflow/providers/amazon/aws/operators/emr.py#L726-L761



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to