ashb commented on a change in pull request #5685: [AIRFLOW-5072] gcs_hook's
download() method should download only once
URL: https://github.com/apache/airflow/pull/5685#discussion_r320650003
##########
File path: tests/contrib/hooks/test_gcs_hook.py
##########
@@ -558,7 +558,7 @@ def test_download_to_file(self, mock_service):
object_name=test_object,
filename=test_file)
- self.assertEqual(response, test_object_bytes)
Review comment:
Does this test now also leave `test_file` file hanging around? (I think it
does.) We should tidy that up with a `try`/`finally`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
