pankajastro commented on code in PR #39348:
URL: https://github.com/apache/airflow/pull/39348#discussion_r1614007306
##########
airflow/providers/google/cloud/operators/kubernetes_engine.py:
##########
@@ -785,16 +786,16 @@ def fetch_cluster_info(self) -> tuple[str, str | None]:
self._ssl_ca_cert = cluster.master_auth.cluster_ca_certificate
return self._cluster_url, self._ssl_ca_cert
- def invoke_defer_method(self):
+ def invoke_defer_method(self, last_log_time: DateTime | None = None):
"""Redefine triggers which are being used in child classes."""
trigger_start_time = utcnow()
self.defer(
trigger=GKEStartPodTrigger(
- pod_name=self.pod.metadata.name,
- pod_namespace=self.pod.metadata.namespace,
+ pod_name=self.pod.metadata.name, # type: ignore[union-attr]
+ pod_namespace=self.pod.metadata.namespace, # type:
ignore[union-attr]
trigger_start_time=trigger_start_time,
- cluster_url=self._cluster_url,
- ssl_ca_cert=self._ssl_ca_cert,
+ cluster_url=self._cluster_url, # type: ignore[arg-type]
+ ssl_ca_cert=self._ssl_ca_cert, # type: ignore[arg-type]
Review Comment:
tested with clean breeze env but it failing
```shell
airflow/providers/google/cloud/operators/kubernetes_engine.py:782: error:
Item
"None" of "Optional[Any]" has no attribute "metadata" [union-attr]
pod_name=self.pod.metadata.name,
^~~~~~~~~~~~~~~~~
airflow/providers/google/cloud/operators/kubernetes_engine.py:783: error:
Item
"None" of "Optional[Any]" has no attribute "metadata" [union-attr]
pod_namespace=self.pod.metadata.namespace,
^~~~~~~~~~~~~~~~~
Found 2 errors in 1 file (checked 1 source file)
Error 1 returned```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
