sanket2000 commented on code in PR #39823:
URL: https://github.com/apache/airflow/pull/39823#discussion_r1614558902
##########
airflow/sensors/base.py:
##########
@@ -322,7 +322,7 @@ def run_duration() -> float:
raise AirflowRescheduleException(reschedule_date)
else:
time.sleep(self._get_next_poke_interval(started_at,
run_duration, poke_count))
- poke_count += 1
+ poke_count += 1
Review Comment:
Ohh correct, sorry missed it. Yes this wont work as TaskInstance object is
recreated at end of schedule. This means to generate next_poke_interval we need
to store the poke_count (or try_number in execute function) somewhere
externally, or infer it from existing information.
I also came across #30669 , i am not sure what would be the next steps to
address this bug :|
PR #30669 pretty much handles this bug
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
