Bowrna commented on code in PR #39729:
URL: https://github.com/apache/airflow/pull/39729#discussion_r1615619468
##########
tests/system/providers/snowflake/example_snowflake.py:
##########
@@ -50,23 +51,25 @@
catchup=False,
) as dag:
# [START howto_operator_snowflake]
- snowflake_op_sql_str = SnowflakeOperator(task_id="snowflake_op_sql_str",
sql=CREATE_TABLE_SQL_STRING)
+ snowflake_op_sql_str = SQLExecuteQueryOperator(
Review Comment:
@potiuk `SnowflakeSqlApiOperator` is an operator to support multiple SQL
statements execution sequentially. so it has inherited from`
SQLExecuteQueryOperator` to support this behaviour and accepts the
`snowflake_conn_id` as its param. that's why I retained both `conn_id` and
`snowflake_conn_id` params in this example. Do you think we can change
`snowflake_conn_id` param in `SnowflakeSqlApiOperator` to `conn_id` itself?
https://github.com/apache/airflow/blob/d5f81a4e2de0d4236cffcf2e2d3c682b4c6ec355/airflow/providers/snowflake/operators/snowflake.py#L391-L494
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
