ashb commented on issue #5787: [AIRFLOW-5172] Add choice of interval edge 
scheduling
URL: https://github.com/apache/airflow/pull/5787#issuecomment-527864906
 
 
   > Really like the spirit of this change. My vote would be to change the flag 
to schedule_at_interval_start and default it to false for now as 
scheduling_at_interval_start is the more intuitive behavior. What are people's 
feelings on changing the default execution to schedule interval start and 
communicating this to existing users in the Updating notes so that they can 
preserve the old behavior? Could potentially cause headaches for users who 
don't read the notes but I think it might make sense to bite the bullet at some 
point for more intuitive behavior overall for new users.
   
   It might be more intuitive to new users but this would mean that every 
single dag in existence right now would need to be updated, so it's a very 
disrputive change.
   
    
   > I haven't looked that carefully, but I think there are potentially a lot 
more places in the code that need to be changed that use 
dag.following_schedule(), e.g. latest_only_operator, cli.py. In fact it might 
make more sense to make the change in the following_schedule function itself. 
There are also functions previous_schedule that might need to be modified too.
   
   Yes, that seems sensible. @iroddis Could you take a look at this and see if 
it makes sense or other places need updating too?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to