shahar1 commented on code in PR #39716:
URL: https://github.com/apache/airflow/pull/39716#discussion_r1617617427


##########
airflow/providers/google/cloud/operators/dataflow.py:
##########
@@ -1358,3 +1359,236 @@ def execute(self, context: Context) -> None:
             self.log.info("No jobs to stop")
 
         return None
+
+
+class DataflowCreatePipelineOperator(GoogleCloudBaseOperator):

Review Comment:
   I think it's better to name it DataflowCreate**Data**PipelineOperator to 
comply with the API's name (same goes for the other operators).
   I'm aware of the wordiness, but it could help avoid confusion with regular 
Dataflow jobs operators. What do you think?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to