pankajkoti commented on code in PR #39771:
URL: https://github.com/apache/airflow/pull/39771#discussion_r1618986336
##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -1039,6 +1123,17 @@ def launch_notebook_job(self) -> int:
self.log.info("Check the job run in Databricks: %s", url)
return self.databricks_run_id
+ def _handle_terminal_run_state(self, run_state):
+ if run_state.life_cycle_state != "TERMINATED":
Review Comment:
This method `_handle_terminal_run_state` is already called once
`Runstate.is_terminal` is reached. This method is called at the end of the
monitoring when the`Runstate.is_terminal` is reached & decided as so when the
`life_cycle_state` is either of ("TERMINATED", "SKIPPED", "INTERNAL_ERROR").
And here, we want to raise an error if it not equal to `TERMINATED`.
This code existed previously too, but it was duplicated in 2 places and
hence I moved this common code to this method now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
