dirrao commented on PR #39908:
URL: https://github.com/apache/airflow/pull/39908#issuecomment-2138489320

   > > That's likely very wrong as it is heavily backwards compatible. It will 
suddenly change almost all dashboards and alerts people built using those 
metrics.
   > > Metrics are definitely "public" API of Airflow and we cannot change them 
without breaking compatibility.
   > 
   > 100% -- this will break all the operational dashboards for companies, 
users and service providers
   
   Yes. This is a breaking change for customers (Datadog and OTEL). As, Statsd 
log the timer metrics in milli seconds. So, the metrics documentation is 
inconsistent unless we make the all the metrics loggers to same metric unit 
(milli seconds). 
   <img width="898" alt="Screen Shot 2024-05-24 at 11 06 41 PM" 
src="https://github.com/apache/airflow/assets/39794726/26ebe405-7b9f-4296-accf-8694942f229d";>
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to