evgeniikozlov commented on issue #37611:
URL: https://github.com/apache/airflow/issues/37611#issuecomment-2139184322

   I found related issue. I don't know if I need to create another issue, 
please let me know if it is required.
   
   ### Apache Airflow version
   2.9.1
   
   ### What happened?
   We use Hashicorp Vault as secrets backend and pass certificate via paramter 
verify, like:
   {
     "AIRFLOW__SECRETS__BACKEND_KWARGS": {
         "verify": "cert_path"
   }
   Starting from version apache-airflow-providers-hashicorp==3.4.2 usage of 
this parameter is broken, is is not used, actually.
   In airflow\providers\hashicorp\_internal_client\vault_client.py, line 207, 
session is created, but parameter "verify" is not passed inside. It is still 
passed to hvac.Client via kwargs (line 212), but inside hvac adapter "verify" 
is filled backwards from session object (hvac.adapters.py, line 97), so the 
original value is missed.
   
   I believe the original problem of @Blizzke is similar. Although, 
VAULT_CAPATH is variable of hvac cleint, and probably original problem can be 
fixed in hvac repo, prioritizing argument "verify"  to session.verify.
   
   ### What you think should happen instead?
   Parameter "verify" is correctly used, via passing it to Session constructor. 
Or, session is not created in vault_client.py (created in hvac client).
   
   ### How to reproduce
   Pass certificate with keyword parameter "verify" to VaultHook constructor.
   
   ### Versions of Apache Airflow Providers
   apache-airflow-providers-hashicorp==3.6.4
   
   ### Code of Conduct
   - [x] I agree to follow this project's [Code of 
Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to