potiuk commented on PR #37948: URL: https://github.com/apache/airflow/pull/37948#issuecomment-2143718995
> I'm not sure what we do usually means, here. Can you clarify? Do you mean we as Apache Airflow, or someone else (OTEL community) ? Also, I'm not sure what using two configs: class or module to use + kwargs to pass means. The thing here is that we are mostly following the "regular" way how OTEL is onfigured (or that's what I understand - @howardyoo to confirm). When you look at OTEL documentation, many of the configuration options there are by the choice of classes and configuring them is mostly about setting the right environment variables or passing a config.yaml file - they read to configure itself. And I think we should keep it this way: * in Airlfow configuration we can configure enabling OTEL and some "airlfow" side of it * we leave the detailed configuration of specific OTEL classes to env variables / yaml files or whatever they need This way we have greater flexibility, do not have to write our own configuration documentation. Also see https://opentelemetry.io/docs/collector/configuration/#environment-variables Hey @hussein-awala -> do you have the questions answered -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
