techolga commented on code in PR #39993:
URL: https://github.com/apache/airflow/pull/39993#discussion_r1623800107
##########
airflow/www/templates/airflow/trigger.html:
##########
@@ -86,8 +86,9 @@
{% endfor -%}
</select>
{% elif form_details.schema and "array" in form_details.schema.type %}
- {% if "items" in form_details.schema and form_details.schema.items %}
- <textarea class="form-control" name="element_{{ form_key }}"
id="element_{{ form_key }}" valuetype="advancedarray" rows="6"
+ {% if "items" in form_details.schema and form_details.schema["items"] %}
+ <textarea class="form-control" name="element_{{ form_key }}"
id="element_{{ form_key }}" rows="6"
+ {%- if "string" in form_details.schema["items"]["type"] %}
valuetype="array"{% else %} valuetype="advancedarray"{% endif -%}
Review Comment:
I just realized that introduces the redundancy unnecessarily, thanks for the
feedback @jscheffl. I just updated my solution. It follows the same behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
