Lukas1v commented on code in PR #39788:
URL: https://github.com/apache/airflow/pull/39788#discussion_r1623951792


##########
airflow/providers/opensearch/hooks/opensearch.py:
##########
@@ -40,13 +44,20 @@ class OpenSearchHook(BaseHook):
     conn_type = "opensearch"
     hook_name = "OpenSearch Hook"
 
-    def __init__(self, open_search_conn_id: str, log_query: bool, **kwargs: 
Any):
+    def __init__(
+        self,
+        open_search_conn_id: str,
+        log_query: bool,
+        open_search_conn_class: type[OpenSearchConnectionClass] | None = 
RequestsHttpConnection,

Review Comment:
   The Opensearch client indeed uses `urllib3` as default, but the hook 
actually defaults to `RequestsHttpConnection`. I chose to keep the hook's 
default to make sure nothing should break.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to