Lee-W commented on code in PR #40013:
URL: https://github.com/apache/airflow/pull/40013#discussion_r1624067400


##########
airflow/providers/databricks/operators/databricks.py:
##########
@@ -1136,28 +1032,71 @@ def _handle_terminal_run_state(self, run_state: 
RunState) -> None:
             )
         self.log.info("Task succeeded. Final state %s.", 
run_state.result_state)
 
+    def _get_current_databricks_task(self):

Review Comment:
   nitpick: missing return typo annotation



##########
tests/system/providers/databricks/example_databricks.py:
##########
@@ -201,6 +202,39 @@
     )
     # [END howto_operator_databricks_notebook_existing_cluster]
 
+    # [START howto_operator_databricks_task_notebook]
+    task_operator_nb_1 = DatabricksTaskOperator(
+        task_id="nb_1",
+        databricks_conn_id="databricks_conn",
+        job_cluster_key="Shared_job_cluster",
+        task_config={
+            "notebook_task": {
+                "notebook_path": "/Shared/Notebook_1",
+                "source": "WORKSPACE",
+            },
+            "libraries": [
+                {"pypi": {"package": "Faker"}},
+                {"pypi": {"package": "simplejson"}},
+            ],
+        },
+    )
+    # [END howto_operator_databricks_task_notebook]
+
+    # [START howto_operator_databricks_task_sql]
+    task_operator_sql_query = DatabricksTaskOperator(
+        task_id="sql_query",
+        databricks_conn_id="databricks_conn",
+        task_config={
+            "sql_task": {
+                "query": {
+                    "query_id": "c9cf6468-babe-41a6-abc3-10ac358c71ee",

Review Comment:
   Is this valid ID or just some random one as an example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to