jscheffl commented on code in PR #39999: URL: https://github.com/apache/airflow/pull/39999#discussion_r1624938278
########## tests/plugins/workday.py: ########## @@ -23,6 +23,9 @@ from __future__ import annotations -from airflow.example_dags.plugins.workday import AfterWorkdayTimetable, WorkdayTimetablePlugin +from airflow.example_dags.plugins.workday import ( + AfterWorkdayTimetable as TestAfterWorkdayTimetable, + WorkdayTimetablePlugin as TestWorkdayTimetablePlugin, +) Review Comment: That renaming was needed as in my first commit the serialization failed with error: `airflow.exceptions.SerializationError: Failed to serialize DAG 'example_workday_timetable': Timetable class 'workday.AfterWorkdayTimetable' is not registered or you have a top level database access that disrupted the session. Please check the airflow best practices documentation.` See first pipeline run in https://github.com/apache/airflow/actions/runs/9333722920/job/25691073318 If you have a "better" idea or know why the serialization test failed if the name from the re-import fails when examples are loaded as well... seems to be a clash in serialization somewhere. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
