e-galan commented on code in PR #39329:
URL: https://github.com/apache/airflow/pull/39329#discussion_r1626073156
##########
airflow/providers/cncf/kubernetes/operators/pod.py:
##########
@@ -112,6 +112,10 @@ class PodReattachFailure(AirflowException):
"""When we expect to be able to find a pod but cannot."""
Review Comment:
We only have one example of `test_exceptions.py.py` in
_tests/providers/docker/test_exceptions.py_. I cannot follow its pattern with
this operator.
Since I added `IdenticalLabelPodError` exception only to replace
`PodReattachFailure` which did not seem to be used anymore, and then it turned
out that I can't just replace it because of the deprecation policy, I don't
think it is that important for me to keep it.
I removed `IdenticalLabelPodError` and put `AirflowException` back in its
place.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
