bbovenzi commented on code in PR #39355:
URL: https://github.com/apache/airflow/pull/39355#discussion_r1626129551


##########
airflow/www/templates/appbuilder/navbar.html:
##########
@@ -50,6 +50,13 @@
         {% include 'appbuilder/navbar_menu.html' %}
       </ul>
       <ul class="nav navbar-nav navbar-right">
+        <li class="active">
+          <div style="padding: 20px; cursor: pointer" id="themeToggleButton">
+            <svg xmlns="http://www.w3.org/2000/svg"; width="16" height="16" 
fill="currentColor" class="bi bi-moon" viewBox="0 0 16 16" 
id="themeToggleButton">

Review Comment:
   Usually when light/dark is toggled the icon changes from a moon to a sun.
   
   Did the material icons for light_mode and dark_mode not work? I'd prefer to 
not add a brand new svg if we don't have to.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to